Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic custom params are disabled upon editing #3076

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Topic custom params are disabled upon editing #3076

wants to merge 10 commits into from

Conversation

David-DB88
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
fixed disabled item on topic edit

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@David-DB88 David-DB88 added type/bug Something isn't working good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted status/confirmed A bug which actuality is confirmed labels Dec 13, 2022
@David-DB88 David-DB88 requested a review from Haarolean December 13, 2022 17:24
@David-DB88 David-DB88 self-assigned this Dec 13, 2022
@David-DB88 David-DB88 linked an issue Dec 13, 2022 that may be closed by this pull request
Topic custom params are disabled upon editing #3071
Closed
@David-DB88 David-DB88 marked this pull request as ready for review December 13, 2022 17:24
@David-DB88 David-DB88 requested a review from a team as a code owner December 13, 2022 17:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Haarolean Haarolean requested a review from a team January 12, 2023 11:06
@Haarolean Haarolean added the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Jan 12, 2023
@Haarolean Haarolean removed good first issue Up for grabs status/accepted An issue which has passed triage and has been accepted status/confirmed A bug which actuality is confirmed labels Jan 12, 2023
@github-actions
Copy link

Custom deployment will be available at http://pr3076.internal.kafka-ui.provectus.io

armenuikafka
armenuikafka suggested changes Jan 12, 2023
View reviewed changes
Copy link

@armenuikafka armenuikafka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In case the Topic was created without any custom parameter, with Edit settings only "retention.bytes" Custom parameter is active in a list
  2. In case with create Topic was added any other custom parameter, with Edit settings it's also active in a list
  3. There are some Parameters which were added with create Topic, but are not displayed with Edit settings
custom.parameter.mov

@David-DB88
Copy link
Contributor Author

this task has not been completed yet

@armenuikafka
Copy link

@iliax could you help us with logic, please? All custom parameters should be active within dropdown with editing topic settings and also added each custom parameter field should always be displayed within topic profile with edit settings?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Haarolean Haarolean assigned Haarolean and unassigned armenuikafka Mar 6, 2023
@Haarolean Haarolean marked this pull request as draft March 15, 2023 14:15
@Haarolean Haarolean removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Mar 24, 2023
@github-actions
Copy link

Custom deployment removed

@Haarolean Haarolean removed their assignment Sep 24, 2023
@dmitry-vlt
Copy link

Is this bug going to be fixed anytime soon?

@Haarolean
Copy link
Contributor

@dmitry-vlt this repo is not maintained (#4255), see https://github.com/kafbat/kafka-ui instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armenuikafka armenuikafka armenuikafka requested changes

@Haarolean Haarolean Awaiting requested review from Haarolean

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topic custom params are disabled upon editing
5 participants
@David-DB88 @armenuikafka @dmitry-vlt @Haarolean @workshur